feat(agents): add Kiro CLI as a preset ACP harness - #3287
Open
FredLackeyOfficial wants to merge 2 commits into
Open
feat(agents): add Kiro CLI as a preset ACP harness#3287FredLackeyOfficial wants to merge 2 commits into
FredLackeyOfficial wants to merge 2 commits into
Conversation
Register kiro-cli acp in PRESET_HARNESSES so Kiro appears as a one-click option in the Agents gallery. Users with Kiro CLI on PATH can select it from Settings without creating a custom harness JSON file. Refs: block#2914 (comment) Signed-off-by: Fred Lackey <[email protected]>
Bundle the Kiro mark as desktop/public/harness-logos/kiro.svg and register it in PRESET_LOGOS so the Agents gallery and Settings panel render the Kiro logo instead of the generic TerminalSquare fallback. Ratchet check-file-sizes.mjs for the +10 lines in discovery.rs. Signed-off-by: Fred Lackey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Register Kiro CLI (
kiro-cli acp) as a tier-2 preset harness so it appears as a one-click option in Settings → Agents without requiring a custom JSON definition.This follows up on the invitation in #2914 (comment) after the generic BYOH system landed in #2773.
Changes
desktop/src-tauri/src/managed_agents/discovery.rs— add aPresetHarnessentry forkiro(command:kiro-cli, args:["acp"])desktop/public/harness-logos/kiro.svg— bundled Kiro logo (purple rounded-rect with ghost mark)desktop/src/features/onboarding/ui/RuntimeIcon.tsx— mapkiro→/harness-logos/kiro.svginPRESET_LOGOSdesktop/public/harness-logos/CREDITS.md— provenance row for the Kiro markdesktop/scripts/check-file-sizes.mjs— ratchetdiscovery.rsline limit (+10 lines)How it was tested
Automated:
cargo fmt --check— cleancargo clippy --lib -- -D warnings— cleancustom_harnessesunit tests pass (includingpreset_ids_are_reservedwhich validates "kiro" is properly reserved)discoveryunit tests passpresetLogos.test.mjs(12 tests) — confirms logo file exists and is mappedProtocol (direct ACP handshake):
initialize→ Kiro responds with V2-compatible capabilities (protocol version 1, agent "Kiro CLI Agent" v2.13.0)session/newwithcwd+mcpServers→ creates session, returns session IDsession/prompt→ streamsagent_message_chunkupdates, returnsstopReason: end_turnManual (desktop app):
just desktop-standaloneon macOS — Kiro appears in Settings → Agents with logokiro-cliis on PATHFollow-up (not in this PR)
The preset is a "dumb launcher" — it does not probe auth status or offer a login hint. A future PR could extend
PresetHarnesswith optional readiness fields (thewhoamiprobe and login guidance mentioned in the #2914 closing comment). Filed separately to keep this PR minimal.Related